He was born in Cardiff and studied at the London School of Economics. He became a solicitor and served on Cardiff City Council. He was Labour MP for Pontypool from 1958 to 1983, and for Torfaen from 1983 to 1987. In 1963 he introduced a private members bill that simplified the divorce law.
He wrote a number of books, including Fellatio, Masochism, Politics and Love (Robson Books, London, 1997) and The bi-sexuality of Daniel Defoe: a psychoanalytic survey of the man and his works (Karnac Books, London, 2006).